fix(billing): Fix on-demand capitalization #100912
Merged
+21
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100912 +/- ##
========================================
Coverage 81.14% 81.14%
========================================
Files 8638 8638
Lines 382966 382966
Branches 24078 24078
========================================
Hits 310740 310740
Misses 71890 71890
Partials 336 336 |
dashed
force-pushed
the
billing/BIL-1646
branch
from
cee1369 to
f8e9e07
Compare
isabellaenriquez
approved these changes
Oct 6, 2025
Addresses PR feedback to keep budget term capitalization in sentence case for step titles and cart text, except when at the beginning of a sentence.
dashed
force-pushed
the
billing/BIL-1646
branch
from
f8e9e07 to
d80738e
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| header={ | ||
| <StepHeader | ||
| title={t('Set your %s limit', activePlan.budgetTerm)} | ||
| title={t('Set your %s limit', displayBudgetName(activePlan))} |
There was a problem hiding this comment.
Bug: Step Title Capitalization Inconsistency
The displayBudgetName(activePlan) call in the step header is missing the {title: true} option. This results in inconsistent capitalization for the step title compared to other title contexts in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/getsentry/issue/BIL-1646/legacy-tiers-correct-capitalization-in-billing-cycle-card